[#686] Wall compilation — Michal Rokos <michal@...>
Hi everybody,
9 messages
2003/01/15
[#688] mkmf.rb - add files to clean and distclean targets — Michal Rokos <michal@...>
Hi,
25 messages
2003/01/15
[#722] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Mathieu Bouchard <matju@...>
2003/01/20
On Thu, 16 Jan 2003, Michal Rokos wrote:
[#740] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— matz@... (Yukihiro Matsumoto)
2003/01/21
Hi,
[#741] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— nobu.nokada@...
2003/01/21
Hi,
[#742] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Alexander Bokovoy <a.bokovoy@...>
2003/01/21
On Tue, Jan 21, 2003 at 11:16:39AM +0900, Yukihiro Matsumoto wrote:
[#744] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— matz@... (Yukihiro Matsumoto)
2003/01/21
Hi,
[#746] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Alexander Bokovoy <a.bokovoy@...>
2003/01/21
On Tue, Jan 21, 2003 at 06:38:00PM +0900, Yukihiro Matsumoto wrote:
[#749] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— matz@... (Yukihiro Matsumoto)
2003/01/21
Hi,
[#750] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Alexander Bokovoy <a.bokovoy@...>
2003/01/21
On Tue, Jan 21, 2003 at 11:37:35PM +0900, Yukihiro Matsumoto wrote:
[#692] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— nobu.nokada@...
2003/01/16
Hi,
[#700] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Michal Rokos <michal@...>
2003/01/16
Hello,
[#702] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— nobu.nokada@...
2003/01/16
Hi,
[#705] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Michal Rokos <michal@...>
2003/01/16
Hi,
[#706] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— nobu.nokada@...
2003/01/16
Hi,
[#707] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Michal Rokos <michal@...>
2003/01/16
Hi,
[#708] Documentation for thread.rb — Gavin Sinclair <gsinclair@...>
Hi ruby-core,
4 messages
2003/01/16
[#719] nd_end and NODE_NEWLINE (fwd) — Chad Fowler <chad@...>
8 messages
2003/01/19
[#724] Symbols: More Functionality Wanted — Ryan Pavlik <rpav@...>
I've been discussing this for a bit on #ruby-lang on OPN (or freenode or
23 messages
2003/01/20
[#728] Re: Symbols: More Functionality Wanted
— matz@... (Yukihiro Matsumoto)
2003/01/20
Hi,
[#743] Re: Symbols: More Functionality Wanted
— "Pit Capitain" <pit@...>
2003/01/21
On 20 Jan 2003 at 15:49, Yukihiro Matsumoto wrote:
[#767] Re: Symbols: More Functionality Wanted
— Mathieu Bouchard <matju@...>
2003/01/22
[#768] Re: Symbols: More Functionality Wanted
— dblack@...
2003/01/22
Hi --
[#779] Re: Symbols: More Functionality Wanted
— Gavin Sinclair <gsinclair@...>
2003/01/23
On Thursday, January 23, 2003, 6:28:04 AM, dblack wrote:
[#780] Re: Symbols: More Functionality Wanted
— Matt Armstrong <matt@...>
2003/01/23
Gavin Sinclair <gsinclair@soyabean.com.au> writes:
[#782] Re: Symbols: More Functionality Wanted
— matz@... (Yukihiro Matsumoto)
2003/01/23
Hi,
[#783] Re: Symbols: More Functionality Wanted
— Matt Armstrong <matt@...>
2003/01/23
matz@ruby-lang.org (Yukihiro Matsumoto) writes:
[#784] Re: Symbols: More Functionality Wanted
— matz@... (Yukihiro Matsumoto)
2003/01/23
Hi,
[#787] Re: Symbols: More Functionality Wanted
— Ryan Pavlik <rpav@...>
2003/01/23
On Fri, 24 Jan 2003 03:34:46 +0900
[#730] Comments on matrix.rb — Gavin Sinclair <gsinclair@...>
Hi -core,
5 messages
2003/01/20
[#757] Extensions for Time and ParseDate — Ryan Davis <ryand-ruby@...>
Eric and I have been hacking around and we can't stand the lack of
8 messages
2003/01/22
[#759] Adding Test::Unit to CVS — "Nathaniel Talbott" <nathaniel@...>
Matz has already given me the go-ahead to add Test::Unit to CVS, but I
11 messages
2003/01/22
[#764] Re: Adding Test::Unit to CVS
— Dave Thomas <dave@...>
2003/01/22
Nathaniel Talbott wrote:
[#770] Re: Adding Test::Unit to CVS
— Ryan Davis <ryand-ruby@...>
2003/01/22
On Wednesday, January 22, 2003, at 07:56 AM, Dave Thomas wrote:
Re: [Patch] Wall compilation
From:
Michal Rokos <michal@...>
Date:
2003-01-16 12:22:01 UTC
List:
ruby-core #701
Hi, nobu.nokada@softhome.net wrote: > At Thu, 16 Jan 2003 15:38:09 +0900, > Michal Rokos wrote: > >>>> If you read the patch, please note change in defines.h >>>> FLUSH_REGISTER_WINDOWS is now defined everytime, but >>>> compilation with -O2 handles empty proc body quite well >>>> (ie. no code - no useless jumps). >>> >>>Is it needed? >> >> Try -Wall compilation. It warns badly (gcc-3.2.2) about the >> code has no effect and so on, which looks ugly to me. This >> patch has the same result (code has no effect), but without >> warnings from compiler. > > >>>What about ((void)0) ? >> >> Again - gcc warns about 'code has no effect'... > > > I've used this (void)0 trick many times, we have to replace > them all to make gcc 3.2.2 quiet? > > Anyhow, what it defines assert() in <assert.h> if NDEBUG? You're right - as usually :)) Thank you for giving me a lesson :) Here's a small patch that does what nobu says. Michal
Attachments (1)
RubyWall2.diff
(1.56 KB, text/x-diff)
Index: defines.h
===================================================================
RCS file: /src/ruby/defines.h,v
retrieving revision 1.26
diff -u -p -r1.26 defines.h
--- defines.h 16 Jan 2003 07:38:39 -0000 1.26
+++ defines.h 16 Jan 2003 12:15:03 -0000
@@ -137,10 +137,10 @@ void xfree _((void*));
#define EXTERN extern
#endif
+#if defined(sparc) || defined(__sparc__)
static inline void
flush_register_windows(void)
{
-#if defined(sparc) || defined(__sparc__)
# if defined(__sparc_v9__) || defined(__arch64__)
asm volatile ("flushw" : :);
# elif defined(linux) || defined(__linux__)
@@ -148,9 +148,11 @@ flush_register_windows(void)
# else /* Solaris, OpenBSD, NetBSD, etc. */
asm volatile ("ta 0x03");
# endif /* trap always to flush register windows if we are on a Sparc system */
-#endif
}
-#define FLUSH_REGISTER_WINDOWS flush_register_windows()
+# define FLUSH_REGISTER_WINDOWS flush_register_windows()
+#else
+# define FLUSH_REGISTER_WINDOWS ((void)0)
+#endif
#if defined(DOSISH)
#define PATH_SEP ";"
Index: eval.c
===================================================================
RCS file: /src/ruby/eval.c,v
retrieving revision 1.386
diff -u -p -r1.386 eval.c
--- eval.c 16 Jan 2003 07:38:39 -0000 1.386
+++ eval.c 16 Jan 2003 12:16:26 -0000
@@ -938,7 +938,7 @@ static void call_trace_func _((char*,NOD
#define SET_CURRENT_SOURCE() (ruby_sourcefile = ruby_current_node->nd_file, \
ruby_sourceline = nd_line(ruby_current_node))
#else
-#define SET_CURRENT_SOURCE() do { } while (0)
+#define SET_CURRENT_SOURCE() ((void)0)
#endif
void