[#686] Wall compilation — Michal Rokos <michal@...>
Hi everybody,
9 messages
2003/01/15
[#688] mkmf.rb - add files to clean and distclean targets — Michal Rokos <michal@...>
Hi,
25 messages
2003/01/15
[#722] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Mathieu Bouchard <matju@...>
2003/01/20
On Thu, 16 Jan 2003, Michal Rokos wrote:
[#740] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— matz@... (Yukihiro Matsumoto)
2003/01/21
Hi,
[#741] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— nobu.nokada@...
2003/01/21
Hi,
[#742] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Alexander Bokovoy <a.bokovoy@...>
2003/01/21
On Tue, Jan 21, 2003 at 11:16:39AM +0900, Yukihiro Matsumoto wrote:
[#744] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— matz@... (Yukihiro Matsumoto)
2003/01/21
Hi,
[#746] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Alexander Bokovoy <a.bokovoy@...>
2003/01/21
On Tue, Jan 21, 2003 at 06:38:00PM +0900, Yukihiro Matsumoto wrote:
[#749] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— matz@... (Yukihiro Matsumoto)
2003/01/21
Hi,
[#750] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Alexander Bokovoy <a.bokovoy@...>
2003/01/21
On Tue, Jan 21, 2003 at 11:37:35PM +0900, Yukihiro Matsumoto wrote:
[#692] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— nobu.nokada@...
2003/01/16
Hi,
[#700] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Michal Rokos <michal@...>
2003/01/16
Hello,
[#702] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— nobu.nokada@...
2003/01/16
Hi,
[#705] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Michal Rokos <michal@...>
2003/01/16
Hi,
[#706] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— nobu.nokada@...
2003/01/16
Hi,
[#707] Re: [RFC] mkmf.rb - add files to clean and distclean targets
— Michal Rokos <michal@...>
2003/01/16
Hi,
[#708] Documentation for thread.rb — Gavin Sinclair <gsinclair@...>
Hi ruby-core,
4 messages
2003/01/16
[#719] nd_end and NODE_NEWLINE (fwd) — Chad Fowler <chad@...>
8 messages
2003/01/19
[#724] Symbols: More Functionality Wanted — Ryan Pavlik <rpav@...>
I've been discussing this for a bit on #ruby-lang on OPN (or freenode or
23 messages
2003/01/20
[#728] Re: Symbols: More Functionality Wanted
— matz@... (Yukihiro Matsumoto)
2003/01/20
Hi,
[#743] Re: Symbols: More Functionality Wanted
— "Pit Capitain" <pit@...>
2003/01/21
On 20 Jan 2003 at 15:49, Yukihiro Matsumoto wrote:
[#767] Re: Symbols: More Functionality Wanted
— Mathieu Bouchard <matju@...>
2003/01/22
[#768] Re: Symbols: More Functionality Wanted
— dblack@...
2003/01/22
Hi --
[#779] Re: Symbols: More Functionality Wanted
— Gavin Sinclair <gsinclair@...>
2003/01/23
On Thursday, January 23, 2003, 6:28:04 AM, dblack wrote:
[#780] Re: Symbols: More Functionality Wanted
— Matt Armstrong <matt@...>
2003/01/23
Gavin Sinclair <gsinclair@soyabean.com.au> writes:
[#782] Re: Symbols: More Functionality Wanted
— matz@... (Yukihiro Matsumoto)
2003/01/23
Hi,
[#783] Re: Symbols: More Functionality Wanted
— Matt Armstrong <matt@...>
2003/01/23
matz@ruby-lang.org (Yukihiro Matsumoto) writes:
[#784] Re: Symbols: More Functionality Wanted
— matz@... (Yukihiro Matsumoto)
2003/01/23
Hi,
[#787] Re: Symbols: More Functionality Wanted
— Ryan Pavlik <rpav@...>
2003/01/23
On Fri, 24 Jan 2003 03:34:46 +0900
[#730] Comments on matrix.rb — Gavin Sinclair <gsinclair@...>
Hi -core,
5 messages
2003/01/20
[#757] Extensions for Time and ParseDate — Ryan Davis <ryand-ruby@...>
Eric and I have been hacking around and we can't stand the lack of
8 messages
2003/01/22
[#759] Adding Test::Unit to CVS — "Nathaniel Talbott" <nathaniel@...>
Matz has already given me the go-ahead to add Test::Unit to CVS, but I
11 messages
2003/01/22
[#764] Re: Adding Test::Unit to CVS
— Dave Thomas <dave@...>
2003/01/22
Nathaniel Talbott wrote:
[#770] Re: Adding Test::Unit to CVS
— Ryan Davis <ryand-ruby@...>
2003/01/22
On Wednesday, January 22, 2003, at 07:56 AM, Dave Thomas wrote:
Re: [RFC] mkmf.rb - add files to clean and distclean targets
From:
Michal Rokos <michal@...>
Date:
2003-01-16 12:04:47 UTC
List:
ruby-core #700
Hello,
nobu.nokada@softhome.net wrote:
> You'd better initialize those globals in init_mkmf, or you may
> have problems when you put extension libraries use them under
> ext/.
Thank you for your comments.
Here's the new version.
Index: lib/mkmf.rb
===================================================================
RCS file: /src/ruby/lib/mkmf.rb,v
retrieving revision 1.123
diff -u -p -r1.123 mkmf.rb
--- lib/mkmf.rb 31 Dec 2002 12:31:12 -0000 1.123
+++ lib/mkmf.rb 16 Jan 2003 12:01:30 -0000
@@ -637,8 +637,6 @@ def create_makefile(target, srcprefix =
target = nil if $objs == ""
- cleanfiles = []
- distcleanfiles = []
if target and EXPORT_PREFIX
origdef = target + '.def'
deffile = EXPORT_PREFIX + origdef
@@ -663,7 +661,7 @@ def create_makefile(target, srcprefix =
end
end
end
- distcleanfiles << deffile unless deffile == origdef
+ $distcleanfiles << deffile unless deffile == origdef
end
libpath = libpathflag(libpath)
@@ -675,8 +673,8 @@ def create_makefile(target, srcprefix =
LIBPATH = #{libpath}
DEFFILE = #{deffile}
-CLEANFILES = #{cleanfiles.join(' ')}
-DISTCLEANFILES = #{distcleanfiles.join(' ')}
+CLEANFILES = #{$cleanfiles.join(' ')}
+DISTCLEANFILES = #{$distcleanfiles.join(' ')}
target_prefix = #{target_prefix}
LOCAL_LIBS = #{$LOCAL_LIBS}
@@ -807,11 +805,15 @@ def init_mkmf(config = CONFIG)
end
$LOCAL_LIBS = ""
- dir_config("opt")
+
+ $cleanfiles = []
+ $distcleanfiles = []
+
+ dir_config("opt") # Twice??? Here.
end
init_mkmf
-dir_config("opt")
+dir_config("opt") # And here?
$make = with_config("make-prog", ENV["MAKE"] || "make")
$nmake = nil
Is this one better?
My question is: Why dir_config is called twice? Once in init_mkmf and
once just after init_mkmf...
Michal