[#686] Wall compilation — Michal Rokos <michal@...>
Hi everybody,
[#688] mkmf.rb - add files to clean and distclean targets — Michal Rokos <michal@...>
Hi,
On Thu, 16 Jan 2003, Michal Rokos wrote:
Hi,
Hi,
On Tue, Jan 21, 2003 at 11:16:39AM +0900, Yukihiro Matsumoto wrote:
Hi,
On Tue, Jan 21, 2003 at 06:38:00PM +0900, Yukihiro Matsumoto wrote:
Hi,
On Tue, Jan 21, 2003 at 11:37:35PM +0900, Yukihiro Matsumoto wrote:
Hi,
Hello,
Hi,
Hi,
Hi,
Hi,
[#708] Documentation for thread.rb — Gavin Sinclair <gsinclair@...>
Hi ruby-core,
[#719] nd_end and NODE_NEWLINE (fwd) — Chad Fowler <chad@...>
[#724] Symbols: More Functionality Wanted — Ryan Pavlik <rpav@...>
I've been discussing this for a bit on #ruby-lang on OPN (or freenode or
Hi,
On 20 Jan 2003 at 15:49, Yukihiro Matsumoto wrote:
Hi --
On Thursday, January 23, 2003, 6:28:04 AM, dblack wrote:
Gavin Sinclair <gsinclair@soyabean.com.au> writes:
Hi,
matz@ruby-lang.org (Yukihiro Matsumoto) writes:
Hi,
On Fri, 24 Jan 2003 03:34:46 +0900
[#730] Comments on matrix.rb — Gavin Sinclair <gsinclair@...>
Hi -core,
[#757] Extensions for Time and ParseDate — Ryan Davis <ryand-ruby@...>
Eric and I have been hacking around and we can't stand the lack of
[#759] Adding Test::Unit to CVS — "Nathaniel Talbott" <nathaniel@...>
Matz has already given me the go-ahead to add Test::Unit to CVS, but I
Nathaniel Talbott wrote:
On Wednesday, January 22, 2003, at 07:56 AM, Dave Thomas wrote:
Re: [Patch] Wall compilation
Hi,
At Thu, 16 Jan 2003 06:35:45 +0900,
Michal Rokos wrote:
> If you read the patch, please note change in defines.h
> FLUSH_REGISTER_WINDOWS is now defined everytime, but
> compilation with -O2 handles empty proc body quite well
> (ie. no code - no useless jumps).
Is it needed?
> Index: dln.c
> ===================================================================
> RCS file: /src/ruby/dln.c,v
> retrieving revision 1.48
> diff -u -p -r1.48 dln.c
> --- dln.c 31 Dec 2002 10:53:14 -0000 1.48
> +++ dln.c 15 Jan 2003 20:52:42 -0000
> @@ -1304,7 +1304,7 @@ dln_load(file)
>
> char *buf;
> /* Load the file as an object one */
> - init_funcname(&buf, file);
> + init_funcname(&buf, (char *)file);
Second argument of init_funcname() is const char*, so this cast
doesn't seem necessery.
> Index: eval.c
> ===================================================================
> RCS file: /src/ruby/eval.c,v
> retrieving revision 1.384
> diff -u -p -r1.384 eval.c
> --- eval.c 15 Jan 2003 08:07:41 -0000 1.384
> +++ eval.c 15 Jan 2003 20:52:50 -0000
> @@ -938,7 +938,7 @@ static void call_trace_func _((char*,NOD
> #define SET_CURRENT_SOURCE() (ruby_sourcefile = ruby_current_node->nd_file, \
> ruby_sourceline = nd_line(ruby_current_node))
> #else
> -#define SET_CURRENT_SOURCE() 0
> +#define SET_CURRENT_SOURCE() do { } while (0)
What about ((void)0) ?
> @@ -2181,6 +2181,8 @@ call_trace_func(event, node, self, id, k
> if (state) JUMP_TAG(state);
> }
>
> +VALUE rb_check_array_type _((VALUE));
> +
Isn't it declared in intern.h?
> Index: ext/readline/readline.c
> ===================================================================
> RCS file: /src/ruby/ext/readline/readline.c,v
> retrieving revision 1.11
> diff -u -p -r1.11 readline.c
> --- ext/readline/readline.c 30 Aug 2002 10:41:57 -0000 1.11
> +++ ext/readline/readline.c 15 Jan 2003 20:53:08 -0000
> @@ -3,6 +3,7 @@
>
> #include <errno.h>
> #include <stdio.h>
> +#include <unistd.h>
> #include <readline/readline.h>
> #include <readline/history.h>
It may be better to surround with HAVE_UNISTD_H.
> Index: ext/stringio/stringio.c
> ===================================================================
> RCS file: /src/ruby/ext/stringio/stringio.c,v
> retrieving revision 1.12
> diff -u -p -r1.12 stringio.c
> --- ext/stringio/stringio.c 20 Dec 2002 11:23:40 -0000 1.12
> +++ ext/stringio/stringio.c 15 Jan 2003 20:53:12 -0000
This patch is OK.
--
Nobu Nakada