[#796] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579)) — Sean Chittenden <sean@...>
> sean@chittenden.org wrote:
33 messages
2003/02/06
[#798] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— matz@... (Yukihiro Matsumoto)
2003/02/06
Hi,
[#826] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— Sean Chittenden <sean@...>
2003/02/10
> |I have read the thread and I think this is a pretty bad change. I
[#827] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— nobu.nokada@...
2003/02/10
Hi,
[#828] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— Sean Chittenden <sean@...>
2003/02/11
> > #BEGIN test.rb
[#829] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— matz@... (Yukihiro Matsumoto)
2003/02/11
Hi,
[#831] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— dblack@...
2003/02/11
Hi --
[#832] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— nobu.nokada@...
2003/02/11
Hi,
[#833] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— dblack@...
2003/02/11
Hi --
[#845] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— matz@... (Yukihiro Matsumoto)
2003/02/11
Hi,
[#846] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— nobu.nokada@...
2003/02/11
Hi,
[#848] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— matz@... (Yukihiro Matsumoto)
2003/02/11
Hi,
[#850] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— stillflame@...
2003/02/11
what about if attr_accessor :foo defined three methods - #foo, #foo=, and
[#830] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— Sean Chittenden <sean@...>
2003/02/11
> |What was wrong with having the receiver set the return value though?
[#834] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— Matt Armstrong <matt@...>
2003/02/11
Sean Chittenden <sean@chittenden.org> writes:
[#835] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— Sean Chittenden <sean@...>
2003/02/11
> > f = Foo.new()
[#838] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— "J.Herre" <jlst@...>
2003/02/11
[#839] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— ts <decoux@...>
2003/02/11
>>>>> "J" == J Herre <jlst@gettysgroup.com> writes:
[#854] Re: value of assignment (Re: Order of the value of an expression changed? (PR#579))
— "Pit Capitain" <pit@...>
2003/02/11
On 11 Feb 2003 at 11:13, Sean Chittenden wrote:
[#801] class of $1, $2 in 1.8.0 — dblack@...
Hi --
31 messages
2003/02/07
[#802] Re: class of $1, $2 in 1.8.0
— nobu.nokada@...
2003/02/07
Hi,
[#803] Re: class of $1, $2 in 1.8.0
— dblack@...
2003/02/07
Hi --
[#804] Re: class of $1, $2 in 1.8.0
— matz@... (Yukihiro Matsumoto)
2003/02/07
Hi,
[#805] Re: class of $1, $2 in 1.8.0
— dblack@...
2003/02/07
Hi --
[#806] Re: class of $1, $2 in 1.8.0
— "J.Herre" <jlst@...>
2003/02/07
[#807] Re: class of $1, $2 in 1.8.0
— Matt Armstrong <matt@...>
2003/02/07
J.Herre <jlst@gettysgroup.com> writes:
[#808] Re: class of $1, $2 in 1.8.0
— dblack@...
2003/02/07
Hi --
[#809] Re: class of $1, $2 in 1.8.0
— Ryan Pavlik <rpav@...>
2003/02/07
On Sat, 8 Feb 2003 06:52:17 +0900
[#810] Re: class of $1, $2 in 1.8.0
— dblack@...
2003/02/07
Hi --
[#812] Re: class of $1, $2 in 1.8.0
— "J.Herre" <jlst@...>
2003/02/08
On Friday, February 7, 2003, at 03:15 PM, dblack@candle.superlink.net
[#851] Alternate GC ? — Mathieu Bouchard <matju@...>
6 messages
2003/02/11
[#875] OpenSSL for Ruby 0.2.0-pre0 — Michal Rokos <michal@...>
Hi everybody!
5 messages
2003/02/24
[#889] Bob Jenkins' hashing implementation in Ruby — Mauricio Fern疣dez <batsman.geo@...>
16 messages
2003/02/28
[#892] Re: Bob Jenkins' hashing implementation in Ruby
— ts <decoux@...>
2003/03/01
>>>>> "M" == Mauricio Fern疣dez <Mauricio> writes:
[#893] Re: Bob Jenkins' hashing implementation in Ruby
— Mauricio Fern疣dez <batsman.geo@...>
2003/03/01
On Sat, Mar 01, 2003 at 08:42:40PM +0900, ts wrote:
[#894] Re: Bob Jenkins' hashing implementation in Ruby
— ts <decoux@...>
2003/03/01
>>>>> "M" == Mauricio Fern疣dez <Mauricio> writes:
[#895] Re: Bob Jenkins' hashing implementation in Ruby
— Mauricio Fern疣dez <batsman.geo@...>
2003/03/01
On Sat, Mar 01, 2003 at 10:03:47PM +0900, ts wrote:
[#896] Re: Bob Jenkins' hashing implementation in Ruby
— ts <decoux@...>
2003/03/01
>>>>> "M" == Mauricio Fern疣dez <Mauricio> writes:
[#897] Re: Bob Jenkins' hashing implementation in Ruby
— Mauricio Fern疣dez <batsman.geo@...>
2003/03/01
On Sat, Mar 01, 2003 at 10:10:35PM +0900, ts wrote:
[#898] Re: Bob Jenkins' hashing implementation in Ruby
— nobu.nokada@...
2003/03/01
Hi,
[#890] String and (repost) MemLeak — Michal Rokos <michal@...>
Hi,
12 messages
2003/02/28
[#907] Re: [Patch] String and (repost) MemLeak
— matz@... (Yukihiro Matsumoto)
2003/03/03
Hi,
[#909] Re: [Patch] String and (repost) MemLeak
— Michal Rokos <michal@...>
2003/03/03
Hi,
[#910] Re: [Patch] String and (repost) MemLeak
— matz@... (Yukihiro Matsumoto)
2003/03/04
Hi,
[#911] Re: [Patch] String and (repost) MemLeak
— Michal Rokos <michal@...>
2003/03/04
Hi,
[Patch] String and (repost) MemLeak
From:
Michal Rokos <michal@...>
Date:
2003-02-28 20:47:30 UTC
List:
ruby-core #890
Hi,
1 memleak hasn't been fixed - I (still) think that there could be a
problem... (REPOSTING)
Index: dir.c
===================================================================
RCS file: /src/ruby/dir.c,v
retrieving revision 1.82
diff -u -p -r1.82 dir.c
--- dir.c 16 Jan 2003 07:34:01 -0000 1.82
+++ dir.c 28 Jan 2003 18:24:39 -0000
@@ -778,6 +778,7 @@ glob_helper(path, sub, flags, func, arg)
sprintf(buf, "%s%s%s", base, (BASE) ? "/" : "",
dp->d_name);
if (lstat(buf, &st) < 0) {
if (errno != ENOENT) rb_sys_warning(buf);
+ free(buf);
continue;
}
if (S_ISDIR(st.st_mode)) {
And I've seen that Matz removed MEMZERO(), but I think there could be a
problem with ->len...
Index: string.c
===================================================================
RCS file: /src/ruby/string.c,v
retrieving revision 1.147
diff -u -p -r1.147 string.c
--- string.c 27 Feb 2003 08:04:32 -0000 1.147
+++ string.c 28 Feb 2003 20:40:42 -0000
@@ -64,12 +64,15 @@ str_new(klass, ptr, len)
}
str = str_alloc(klass);
- RSTRING(str)->len = len;
RSTRING(str)->aux.capa = len;
RSTRING(str)->ptr = ALLOC_N(char,len+1);
if (ptr) {
memcpy(RSTRING(str)->ptr, ptr, len);
}
+ else {
+ len = 0;
+ }
+ RSTRING(str)->len = len;
RSTRING(str)->ptr[len] = '\0';
return str;
}
Any comments? Are my doubts odd?
Michal