[#80531] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip] — Eric Wong <normalperson@...>
SASADA Koichi <ko1@ruby-lang.org> wrote:
24 messages
2017/04/02
[#80532] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/04/02
On 2017/04/02 11:35, Eric Wong wrote:
[#80540] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— Eric Wong <normalperson@...>
2017/04/03
SASADA Koichi <ko1@atdot.net> wrote:
[#81027] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— Eric Wong <normalperson@...>
2017/05/08
Eric Wong <normalperson@yhbt.net> wrote:
[#81028] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/05/08
On 2017/05/08 9:33, Eric Wong wrote:
[#81029] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/05/08
On 2017/05/08 10:53, SASADA Koichi wrote:
[#81031] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— Eric Wong <normalperson@...>
2017/05/08
SASADA Koichi <ko1@atdot.net> wrote:
[#81033] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/05/08
On 2017/05/08 12:01, Eric Wong wrote:
[#81035] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— Eric Wong <normalperson@...>
2017/05/08
SASADA Koichi <ko1@atdot.net> wrote:
[#81042] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/05/09
On 2017/05/08 15:36, Eric Wong wrote:
[#81044] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— Eric Wong <normalperson@...>
2017/05/09
SASADA Koichi <ko1@atdot.net> wrote:
[#81045] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/05/09
On 2017/05/09 12:38, Eric Wong wrote:
[#81047] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— Eric Wong <normalperson@...>
2017/05/09
SASADA Koichi <ko1@atdot.net> wrote:
[#81049] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/05/09
On 2017/05/09 14:12, Eric Wong wrote:
[#81053] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— Eric Wong <normalperson@...>
2017/05/09
SASADA Koichi <ko1@atdot.net> wrote:
[#81054] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/05/09
On 2017/05/09 15:23, Eric Wong wrote:
[#81078] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— Eric Wong <normalperson@...>
2017/05/09
SASADA Koichi <ko1@atdot.net> wrote:
[#81083] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip]
— SASADA Koichi <ko1@...>
2017/05/10
Thank you.
[#80763] [Ruby trunk Feature#13434] better method definition in C API — naruse@...
Issue #13434 has been updated by naruse (Yui NARUSE).
3 messages
2017/04/18
[#80844] [Ruby trunk Bug#13503] Improve performance of some Time & Rational methods — watson1978@...
Issue #13503 has been updated by watson1978 (Shizuo Fujita).
4 messages
2017/04/24
[#80892] [Ruby trunk Misc#13514] [PATCH] thread_pthread.c (native_sleep): preserve old unblock function — ko1@...
Issue #13514 has been updated by ko1 (Koichi Sasada).
8 messages
2017/04/26
[#80894] Re: [Ruby trunk Misc#13514] [PATCH] thread_pthread.c (native_sleep): preserve old unblock function
— Eric Wong <normalperson@...>
2017/04/26
ko1@atdot.net wrote:
[#80895] Re: [Ruby trunk Misc#13514] [PATCH] thread_pthread.c (native_sleep): preserve old unblock function
— SASADA Koichi <ko1@...>
2017/04/27
On 2017/04/27 8:58, Eric Wong wrote:
[#80897] Re: [Ruby trunk Misc#13514] [PATCH] thread_pthread.c (native_sleep): preserve old unblock function
— Eric Wong <normalperson@...>
2017/04/27
SASADA Koichi <ko1@atdot.net> wrote:
[#80898] Re: [Ruby trunk Misc#13514] [PATCH] thread_pthread.c (native_sleep): preserve old unblock function
— Eric Wong <normalperson@...>
2017/04/27
Eric Wong <normalperson@yhbt.net> wrote:
[ruby-core:80849] [Ruby trunk Feature#12944] Change Kernel#warn to call Warning.warn
From:
eregontp@...
Date:
2017-04-24 20:40:33 UTC
List:
ruby-core #80849
Issue #12944 has been updated by Eregon (Benoit Daloze).
It seems it is a compatibility issue.
For instance Thread.exclusive warning is now printed incorrectly:
~~~
$ ruby -ve 'def m; Thread.exclusive {}; end; m'
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]
Thread.exclusive is deprecated, use Thread::Mutex
-e:1:in `m'
-e:1:in `<main>'
$ ruby -ve 'def m; Thread.exclusive {}; end; m'
ruby 2.5.0dev (2017-04-24 trunk 58466) [x86_64-linux]
Thread.exclusive is deprecated, use Thread::Mutex
["-e:1:in `m'", "-e:1:in `<main>'"]
~~~
The fix is easy:
~~~ diff
def self.exclusive
- warn "Thread.exclusive is deprecated, use Thread::Mutex", caller
+ warn "Thread.exclusive is deprecated, use Thread::Mutex", *caller
MUTEX_FOR_THREAD_EXCLUSIVE.synchronize{
~~~
But this is not the only usage of warn + caller.
https://github.com/search?l=Ruby&p=2&q=warn+caller&type=Code&utf8=%E2%9C%93
I think it would be best to remain compatible and join("\n") #warn's arguments.
----------------------------------------
Feature #12944: Change Kernel#warn to call Warning.warn
https://bugs.ruby-lang.org/issues/12944#change-64454
* Author: jeremyevans0 (Jeremy Evans)
* Status: Closed
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
Currently, Kernel#warn is basically the same as $stderr.puts. With the new Warning.warn support in ruby 2.4, it makes sense for Kernel#warn to call Warning.warn, otherwise you will not be able to use Warning.warn to filter/process warning messages generated by Kernel#warn.
The Kernel#warn API is different than the Warning.warn API, the attached patch tries to get similar behavior, but there are probably corner cases where the behavior is different.
---Files--------------------------------
0001-Change-Kernel-warn-to-call-Warning.warn.patch (1.88 KB)
0001-Change-Kernel-warn-to-call-Warning.warn.patch (1.89 KB)
0001-Change-Kernel-warn-to-call-Warning.warn.patch (2.36 KB)
0001-Change-Kernel-warn-to-call-Warning.warn.patch (2.3 KB)
0001-Change-Kernel-warn-to-call-Warning.warn.patch (3.23 KB)
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>