[#79914] [Ruby trunk Bug#13282] opt_str_freeze does not always dedupe — normalperson@...
Issue #13282 has been reported by Eric Wong.
4 messages
2017/03/05
[#80140] [Ruby trunk Feature#13295] [PATCH] compile.c: apply opt_str_freeze to String#-@ (uminus) — shyouhei@...
Issue #13295 has been updated by shyouhei (Shyouhei Urabe).
5 messages
2017/03/13
[#80362] Re: [Ruby trunk Feature#13295] [PATCH] compile.c: apply opt_str_freeze to String#-@ (uminus)
— Eric Wong <normalperson@...>
2017/03/26
shyouhei@ruby-lang.org wrote:
[#80368] Re: [Ruby trunk Feature#13295] [PATCH] compile.c: apply opt_str_freeze to String#-@ (uminus)
— SASADA Koichi <ko1@...>
2017/03/27
On 2017/03/26 15:16, Eric Wong wrote:
[#80205] Re: [ruby-cvs:65166] duerst:r58000 (trunk): clarifiy 'codepoint' in documentation of String#each_codepoint — Eric Wong <normalperson@...>
duerst@ruby-lang.org wrote:
4 messages
2017/03/17
[#80213] Re: [ruby-cvs:65166] duerst:r58000 (trunk): clarifiy 'codepoint' in documentation of String#each_codepoint
— Martin J. Dürst <duerst@...>
2017/03/17
Hello Eric,
[#80290] [Ruby trunk Feature#13355] [PATCH] compile.c: optimize literal String range in case/when dispatch — normalperson@...
Issue #13355 has been reported by normalperson (Eric Wong).
4 messages
2017/03/23
[#80410] Re: [Ruby trunk Feature#13355] [PATCH] compile.c: optimize literal String range in case/when dispatch
— Eric Wong <normalperson@...>
2017/03/27
normalperson@yhbt.net wrote:
[#80415] [Ruby trunk Feature#12589] VM performance improvement proposal — vmakarov@...
Issue #12589 has been updated by vmakarov (Vladimir Makarov).
5 messages
2017/03/28
[#80488] [Ruby trunk Feature#12589] VM performance improvement proposal — vmakarov@...
Issue #12589 has been updated by vmakarov (Vladimir Makarov).
4 messages
2017/03/29
[ruby-core:80477] [Ruby trunk Bug#13312] String#casecmp raises TypeError instead of returning nil
From:
morita.shingo@...
Date:
2017-03-29 10:11:32 UTC
List:
ruby-core #80477
Issue #13312 has been updated by shingo (shingo morita).
File patch.diff added
I agree this is not expecting behavior. then I made a patch for this.
Added test codes below.
```diff
diff --git a/test/ruby/test_string.rb b/test/ruby/test_string.rb
index 7dbf27e..96b37fd 100644
--- a/test/ruby/test_string.rb
+++ b/test/ruby/test_string.rb
@@ -2318,6 +2318,8 @@ def test_compare_different_encoding_string
def test_casecmp
assert_equal(1, "\u3042B".casecmp("\u3042a"))
+ assert_nil("Foo".casecmp(:Foo))
+ assert_nil("1".casecmp(1))
end
def test_casecmp?
@@ -2325,6 +2327,8 @@ def test_casecmp?
assert_equal(false, 'FoO'.casecmp?('BaR'))
assert_equal(false, 'baR'.casecmp?('FoO'))
assert_equal(true, 'äöü'.casecmp?('ÄÖÜ'))
+ assert_nil("Foo".casecmp?(:Foo))
+ assert_nil("1".casecmp?(1))
end
```
----------------------------------------
Bug #13312: String#casecmp raises TypeError instead of returning nil
https://bugs.ruby-lang.org/issues/13312#change-63972
* Author: stomar (Marcus Stollsteimer)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v: r57964
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
String#casecmp and String#casecmp? behave differently from other comparison methods: for incomparable values they raise a TypeError, while Symbol#{casecmp,casecmp?} and the #<=> methods (also for other classes) return `nil`:
``` ruby
"abc" <=> 1 # => nil
"abc".casecmp 1 # TypeError: no implicit conversion of Integer into String
"abc".casecmp? 1 # TypeError: no implicit conversion of Integer into String
:abc <=> 1 # => nil
:abc.casecmp 1 # => nil
:abc.casecmp? 1 # => nil
1 <=> Time.now # => nil
[] <=> :foo # => nil
```
This is surprising, since String#casecmp is essentially a case-insensitive version of String#<=>, which seems to imply that they should behave in a similar way. Also, the different behavior for String and Symbol might be an indication that this is a bug and not intentional.
---Files--------------------------------
patch.diff (2.5 KB)
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>