[#66126] Creation/Conversion methods/functions table for Ruby types — SASADA Koichi <ko1@...>
Hi,
5 messages
2014/11/07
[#66248] [ruby-trunk - Feature #10423] [PATCH] opt_str_lit*: avoid literal string allocations — normalperson@...
Issue #10423 has been updated by Eric Wong.
3 messages
2014/11/13
[#66595] [ruby-trunk - Bug #10557] [Open] Block not given when the argument is a string — bartosz@...
Issue #10557 has been reported by Bartosz Kopinski.
3 messages
2014/11/30
[ruby-core:66535] [ruby-trunk - Bug #10551] [Closed] Unnecessary #undef in file.c
From:
nobu@...
Date:
2014-11-28 03:39:36 UTC
List:
ruby-core #66535
Issue #10551 has been updated by Nobuyoshi Nakada. Status changed from Open to Closed % Done changed from 0 to 100 Applied in changeset r48629. ---------- file.c: unnecessary #undef * file.c (flock): remove unnecessary #undef flock, trace of green thread polling. patched by Rohan Garg. [Bug #10551] ---------------------------------------- Bug #10551: Unnecessary #undef in file.c https://bugs.ruby-lang.org/issues/10551#change-50150 * Author: Rohan Garg * Status: Closed * Priority: Normal * Assignee: * Category: * Target version: * ruby -v: ruby 2.1.2p95 (2014-05-08) [x86_64-linux-gnu] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN ---------------------------------------- Hi there I was just casually looking at the File locking implementation in ruby inside file.c and noticed that there's a unnecessary #undef flock at the end of the function, maybe it really is required, but I couldn't figure out why. So here's my first patch to ruby, but I'm not totally sure about it. Feel free to correct me if I'm wrong and it really is required, git history didn't tell me much. ---Files-------------------------------- remove_unnecessary_undef.patch (254 Bytes) -- https://bugs.ruby-lang.org/