[ruby-core:66236] Re: [ruby-trunk - Feature #10423] [PATCH] opt_str_lit*: avoid literal string allocations

From: Eric Wong <normalperson@...>
Date: 2014-11-12 22:07:24 UTC
List: ruby-core #66236
ko1@atdot.net wrote:
> >  > 4. (neutral/not big issue) warning on VC (windows)
> >  
> >  Untested patch (cast to unsigned):
> >    http://80x24.org/spew/m/30c309d1ad24319ad53813f8814e09be0554ccb0.txt
> 
> Not solved yet :(
> 
> ```
> C:\ko1\src\ruby\mswin64.git\opt_method.h(216) : warning C4146: 符号付きの値を代入する変数は、符号付き型にキャストしなければなりません。
> C:\ko1\src\ruby\mswin64.git\opt_method.h(221) : warning C4146: 符号付きの値を代入する変数は、符号付き型にキャストしなければなりません。
> C:\ko1\src\ruby\mswin64.git\opt_method.h(226) : warning C4146: 符号付きの値を代入する変数は、符号付き型にキャストしなければなりません。
> ```
> 
> Maybe it says "a variable which assign signed value, you need to cast to signed value."

Maybe this works:

   http://80x24.org/spew/m/opt_str_lit+signed_enum@7.txt

But I am thinking of trying an entirely different approach to this
optimization (also able to target non-cfunc)

In This Thread

Prev Next