[ruby-core:63823] [ruby-trunk - Feature #10058] [PATCH] Fix some coding styles

From: ruby-core@...
Date: 2014-07-18 10:14:24 UTC
List: ruby-core #63823
Issue #10058 has been updated by Marc-Andre Lafortune.


Naohisa Goto: Good point about `__send__`, I imagine it is to avoid classes that redefined `send`? In any case, I revised the uses of `send` in the Matrix lib and they are all to call our own private methods, so I think it's fine like this.

----------------------------------------
Feature #10058: [PATCH] Fix some coding styles
https://bugs.ruby-lang.org/issues/10058#change-47858

* Author: gogo tanaka
* Status: Open
* Priority: Low
* Assignee: Marc-Andre Lafortune
* Category: 
* Target version: 
----------------------------------------
When I read codes, I notice some issues about coding style.

If you don't mind that, you can ignore my patches. It's just coding style problem.

コードを読んでいる中でコーディングスタイルに関して気になる事があったのでPATCHを投げますが、

こちら(redmine, rubyコミュニティ)のコーディングスタイルに対する温度感が掴めてないので

気にする事でなければ、無視してください. 

あげると切りがないので今回は特に気になる以下の三点に絞りました. 

* There are both `&&` and `and`. So, I Unify with `&&` 

* There are both `send :xxx` and `send(:xxx)`  expressions. So, I Unify with `send(:xxx)` 

*  I reorder methods. I think Matrix#real should be upon Matrix#imaginary(From what I see complex.c)

---Files--------------------------------
unify_product_operator.patch (879 Bytes)
reorder_Matrix#real_and_Matrix_imaginary.patch (1.3 KB)
use_method_with_parenthesis.patch (1021 Bytes)


-- 
https://bugs.ruby-lang.org/

In This Thread

Prev Next