[ruby-core:63819] [ruby-trunk - Feature #10058] [PATCH] Fix some coding styles

From: ngotogenome@...
Date: 2014-07-18 09:40:00 UTC
List: ruby-core #63819
Issue #10058 has been updated by Naohisa Goto.


> There are both && and and. So, I Unify with &&

Be careful that "&&" and "and" have different operator precedence, and they can not always be simply replaceable.

 && と and は演算の優先順位が異なるので、単純に置換できない場合もあるのは要注意です。

http://qiita.com/fukayatsu/items/920ad8e4d099c3fec890


By the way, FYI, Rails coding guideline says "Prefer &&/|| over and/or".

関係ありませんが参考までに、Railsのガイドラインには&&/||のほうをand/orより優先して使うように書いてありますね。

http://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions



----------------------------------------
Feature #10058: [PATCH] Fix some coding styles
https://bugs.ruby-lang.org/issues/10058#change-47854

* Author: gogo tanaka
* Status: Open
* Priority: Low
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
When I read codes, I notice some issues about coding style.

If you don't mind that, you can ignore my patches. It's just coding style problem.

コードを読んでいる中でコーディングスタイルに関して気になる事があったのでPATCHを投げますが、

こちら(redmine, rubyコミュニティ)のコーディングスタイルに対する温度感が掴めてないので

気にする事でなければ、無視してください. 

あげると切りがないので今回は特に気になる以下の三点に絞りました. 

* There are both `&&` and `and`. So, I Unify with `&&` 

* There are both `send :xxx` and `send(:xxx)`  expressions. So, I Unify with `send(:xxx)` 

*  I reorder methods. I think Matrix#real should be upon Matrix#imaginary(From what I see complex.c)

---Files--------------------------------
unify_product_operator.patch (879 Bytes)
reorder_Matrix#real_and_Matrix_imaginary.patch (1.3 KB)
use_method_with_parenthesis.patch (1021 Bytes)


-- 
https://bugs.ruby-lang.org/

In This Thread

Prev Next