[ruby-core:99799] [Ruby master Bug#17132] vcs.rb doesn't detect git submodules as vcs
From:
bjorn.bidar@...
Date:
2020-08-31 11:31:10 UTC
List:
ruby-core #99799
Issue #17132 has been updated by Thaodan (Bjn Bidar).
>As I have never used git submodule, I can't get what "target thats inside a submodule" means.
>Could you explain how you set up it?
It means that the target eg. the srcdir is in a git submodule.
It set it up like this:
``` shell
git init
git submodule add https://github.com/ruby/ruby.git
```
>.git file/directory doesn't exist in submodule?
it is but .git contains only the dir of the real git directory instead the main module.
The reason for all this is to keep the upstream source while having the downstream rpm directory in the same tree so that when building a tarball can be generated that is used to build the package in ci system.
----------------------------------------
Bug #17132: vcs.rb doesn't detect git submodules as vcs
https://bugs.ruby-lang.org/issues/17132#change-87317
* Author: Thaodan (Bjn Bidar)
* Status: Feedback
* Priority: Normal
* ruby -v: ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Mostly a followup of #12239 as this was already about a similar use case.
When I run make-snapshot with a srcdir as target thats inside a submodule it doesn't detect it as vcs.
My command line and the output:
`~/dev/sailfish/jolla/pkgs/mer_core/ruby/ruby/:./tool/make-snapshot -srcdir=../$PWD snapshot
Traceback (most recent call last):
1: from ./tool/make-snapshot:584:in `<main>'
/home/bidar/dev/sailfish/jolla/pkgs/mer_core/ruby/ruby/tool/lib/vcs.rb:152:in `detect': does not seem to be under a vcs: ..//home/bidar/dev/sailfish/jolla/pkgs/mer_core/ruby/ruby (VCS::NotFoundError)
`
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>