ruby-core

Issue #15742 has been updated by nobu (Nobuyoshi Nakada).


kaishuu0123 (Koki Oyatsu) wrote:
> I was surprised that handled the omission of era in `Date#jisx0301`.

More surprisingly, it is required by JIS X 0301; its definition is basically non-era, and the era *may* be preceded.
> 必要によっては、年の表示の前に元号を識別する記号を付けてもよい。
> If necessary, the year display may be preceded by a symbol identifying the era.
(translated by google)

> Because I think that it is better not to incorporate features specific to a specific country.
> Basically, I think `Date#jisx0301` may be added by gem.

Totally agree, but not only the particular methods, a kitchen-sink `Date.parse` also incorporates the feature.


----------------------------------------
Misc #15742: Add Date#jisx0301 support new Japanese era
https://bugs.ruby-lang.org/issues/15742#change-77418

* Author: kaishuu0123 (Koki Oyatsu)
* Status: Feedback
* Priority: Normal
* Assignee: 
----------------------------------------
## Reproduce process

```
irb(main):002:0> require 'date'
=> true
irb(main):003:0> Date.new(2019, 5, 1).jisx0301
=> "H31.05.01"
```

* ruby version: trunk

## Result of reproduce process

```
irb(main):003:0> Date.new(2019, 5, 1).jisx0301
=> "H31.05.01"
```

## Expected result and the reason why you expect

```
irb(main):002:0> require 'date'
=> true
irb(main):003:0> Date.new(2019, 5, 1).jisx0301
=> "R01.05.01"
```

### reason

* new era (Reiwa?) starts from 2019/05/01
* refs: https://github.com/ruby/ruby/blob/trunk/ext/date/date_core.c#L7049
* I can't be sure that initial letter is "R".



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>