[#86787] [Ruby trunk Feature#14723] [WIP] sleepy GC — ko1@...
Issue #14723 has been updated by ko1 (Koichi Sasada).
13 messages
2018/05/01
[#86790] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Eric Wong <normalperson@...>
2018/05/01
ko1@atdot.net wrote:
[#86791] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Koichi Sasada <ko1@...>
2018/05/01
On 2018/05/01 12:18, Eric Wong wrote:
[#86792] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Eric Wong <normalperson@...>
2018/05/01
Koichi Sasada <ko1@atdot.net> wrote:
[#86793] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Koichi Sasada <ko1@...>
2018/05/01
On 2018/05/01 12:47, Eric Wong wrote:
[#86794] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Eric Wong <normalperson@...>
2018/05/01
Koichi Sasada <ko1@atdot.net> wrote:
[#86814] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Koichi Sasada <ko1@...>
2018/05/02
[#86815] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Eric Wong <normalperson@...>
2018/05/02
Koichi Sasada <ko1@atdot.net> wrote:
[#86816] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Koichi Sasada <ko1@...>
2018/05/02
On 2018/05/02 11:49, Eric Wong wrote:
[#86847] [Ruby trunk Bug#14732] CGI.unescape returns different instance between Ruby 2.3 and 2.4 — me@...
Issue #14732 has been reported by jnchito (Junichi Ito).
3 messages
2018/05/02
[#86860] [Ruby trunk Feature#14723] [WIP] sleepy GC — sam.saffron@...
Issue #14723 has been updated by sam.saffron (Sam Saffron).
6 messages
2018/05/03
[#86862] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC
— Eric Wong <normalperson@...>
2018/05/03
sam.saffron@gmail.com wrote:
[#86935] [Ruby trunk Bug#14742] Deadlock when autoloading different constants in the same file from multiple threads — elkenny@...
Issue #14742 has been reported by eugeneius (Eugene Kenny).
5 messages
2018/05/08
[#87030] [Ruby trunk Feature#14757] [PATCH] thread_pthread.c: enable thread caceh by default — normalperson@...
Issue #14757 has been reported by normalperson (Eric Wong).
4 messages
2018/05/15
[#87093] [Ruby trunk Feature#14767] [PATCH] gc.c: use monotonic counters for objspace_malloc_increase — ko1@...
Issue #14767 has been updated by ko1 (Koichi Sasada).
3 messages
2018/05/17
[#87095] [Ruby trunk Feature#14767] [PATCH] gc.c: use monotonic counters for objspace_malloc_increase — ko1@...
Issue #14767 has been updated by ko1 (Koichi Sasada).
9 messages
2018/05/17
[#87096] Re: [Ruby trunk Feature#14767] [PATCH] gc.c: use monotonic counters for objspace_malloc_increase
— Eric Wong <normalperson@...>
2018/05/17
ko1@atdot.net wrote:
[#87166] Re: [Ruby trunk Feature#14767] [PATCH] gc.c: use monotonic counters for objspace_malloc_increase
— Eric Wong <normalperson@...>
2018/05/18
Eric Wong <normalperson@yhbt.net> wrote:
[#87486] Re: [Ruby trunk Feature#14767] [PATCH] gc.c: use monotonic counters for objspace_malloc_increase
— Eric Wong <normalperson@...>
2018/06/13
I wrote:
[ruby-core:86852] [Ruby trunk Bug#14732] CGI.unescape returns different instance between Ruby 2.3 and 2.4
From:
me@...
Date:
2018-05-03 00:22:02 UTC
List:
ruby-core #86852
Issue #14732 has been updated by jnchito (Junichi Ito).
normalperson (Eric Wong) wrote:
> > > https://bugs.ruby-lang.org/issues/14732
>
> r63328 This also affects 2.3 for unescapeHTML.
I confirmed r63328, but could not understand the valid specification.
In Ruby 2.3, CGI.escape and CGI.unescape always return String instance regardless of class and value:
~~~ text
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.escape(S.new("a")).class'
ruby 2.3.6p384 (2017-12-14 revision 61254) [x86_64-darwin17]
String
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.escape(S.new(">")).class'
ruby 2.3.6p384 (2017-12-14 revision 61254) [x86_64-darwin17]
String
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.unescape(S.new("a")).class'
ruby 2.3.6p384 (2017-12-14 revision 61254) [x86_64-darwin17]
String
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.unescape(S.new("%3E")).class'
ruby 2.3.6p384 (2017-12-14 revision 61254) [x86_64-darwin17]
String
~~~
In Ruby 2.4, results differ according to argument values:
~~~ text
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.escape(S.new("a")).class'
ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17]
S
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.escape(S.new(">")).class'
ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17]
String
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.unescape(S.new("a")).class'
ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17]
S
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.unescape(S.new("%3E")).class'
ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17]
String
~~~
With r63328, I feel the all results would be the instance of "S" and this behavior is different from Ruby 2.3. But is this valid in Ruby 2.4?
----------------------------------------
Bug #14732: CGI.unescape returns different instance between Ruby 2.3 and 2.4
https://bugs.ruby-lang.org/issues/14732#change-71818
* Author: jnchito (Junichi Ito)
* Status: Closed
* Priority: Normal
* Assignee:
* Target version:
* ruby -v: 2.4.4
* Backport: 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED
----------------------------------------
In Ruby 2.3, CGI.unescape always returns String object:
~~~ ruby
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.unescape(S.new("a")).class'
ruby 2.3.6p384 (2017-12-14 revision 61254) [x86_64-darwin17]
String
~~~
But in Ruby 2.4, it might return non-String object when the argument value is not a String instance:
~~~ ruby
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.unescape(S.new("a")).class'
ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17]
S
~~~
This change triggered the following issue:
https://github.com/rest-client/rest-client/issues/662
Is this change intentional?
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>