[#35027] [Ruby 1.9-Bug#4352][Open] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s) — "James M. Lawrence" <redmine@...>
Bug #4352: [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
16 messages
2011/02/01
[#35041] [Ruby 1.9-Bug#4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
— "James M. Lawrence" <redmine@...>
2011/02/02
Issue #4352 has been updated by James M. Lawrence.
[#35045] Re: [Ruby 1.9-Bug#4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
— Yusuke ENDOH <mame@...>
2011/02/02
Hi,
[#35046] Re: [Ruby 1.9-Bug#4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
— Rocky Bernstein <rockyb@...>
2011/02/02
On Wed, Feb 2, 2011 at 10:47 AM, Yusuke ENDOH <mame@tsg.ne.jp> wrote:
[#35065] Re: [Ruby 1.9-Bug#4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
— Yusuke ENDOH <mame@...>
2011/02/03
Hi,
[#35036] [Ruby 1.9-Bug#4354][Open] File.realdirpath is expected to test for real file. — Luis Lavena <redmine@...>
Bug #4354: File.realdirpath is expected to test for real file.
3 messages
2011/02/02
[#35055] [Ruby 1.9-Bug#4359][Open] regular expressions created with Regexp::FIXEDENCODING have incorrect inspect — Aaron Patterson <redmine@...>
Bug #4359: regular expressions created with Regexp::FIXEDENCODING have incorrect inspect
4 messages
2011/02/02
[#35071] Bug in system()? — Anthony Wright <anthony@...>
I've just hit a problem where the system() method to call an external program failed in a fairly unpredictable way, and I couldn't get any clues from within ruby to diagnose the problem. As a result I ended up debugging process.c to work out what the problem was.
4 messages
2011/02/03
[#35100] [Ruby 1.9-Bug#4370][Open] Abort trap in net/http — David Phillips <redmine@...>
Bug #4370: Abort trap in net/http
4 messages
2011/02/05
[#35114] [Ruby 1.9-Bug#4373][Open] http.rb:677: [BUG] Segmentation fault — Christian Fazzini <redmine@...>
Bug #4373: http.rb:677: [BUG] Segmentation fault
59 messages
2011/02/06
[#35144] Documentation Clarifications to Array methods rotate, rotate!, index, and rindex — Loren Sands-Ramshaw <lorensr@...>
Tue Feb 8 11:47:11 2011 Loren Sands-Ramshaw <lorensr@gmail.com>
3 messages
2011/02/08
[#35146] [Ruby 1.9-Bug#4383][Assigned] psych fails to parse a symbol in a flow sequence — Yuki Sonoda <redmine@...>
Bug #4383: psych fails to parse a symbol in a flow sequence
6 messages
2011/02/08
[#35167] Redmine misconfigured (was Re: Re: [Ruby 1.9-Bug#4340] Encoding of result string for String#gsub is not consistent) — mathew <meta@...>
On Tue, Feb 8, 2011 at 16:27, Eric Hodel <drbrain@segment7.net> wrote:
3 messages
2011/02/09
[#35171] [Ruby 1.9-Bug#4386][Open] encoding: directive does not affect regex expressions — mathew murphy <redmine@...>
Bug #4386: encoding: directive does not affect regex expressions
9 messages
2011/02/09
[#35202] Patch to Net::InternetMessageIO — Daniel Cormier <daniel.cormier@...>
This patch addresses an issue when sending a message with Net::SMTP
7 messages
2011/02/11
[#35206] Re: Patch to Net::InternetMessageIO
— mathew <meta@...>
2011/02/11
On Fri, Feb 11, 2011 at 09:13, Daniel Cormier <daniel.cormier@gmail.com> wrote:
[#35207] Re: Patch to Net::InternetMessageIO
— Daniel Cormier <daniel.cormier@...>
2011/02/11
Perhaps that is a better solution, but shouldn't sending a message
[#35233] Re: Patch to Net::InternetMessageIO
— mathew <meta@...>
2011/02/14
On Fri, Feb 11, 2011 at 17:08, Daniel Cormier <daniel.cormier@gmail.com> wrote:
[#35310] Re: Patch to Net::InternetMessageIO
— Daniel Cormier <daniel.cormier@...>
2011/02/19
Ok, but since the period escaping is already being done (just with
[#35237] [Ruby 1.9-Bug#4400][Open] nested at_exit hooks run in strange order — Suraj Kurapati <redmine@...>
Bug #4400: nested at_exit hooks run in strange order
12 messages
2011/02/15
[#35249] [Ruby 1.9-Bug#4400] nested at_exit hooks run in strange order
— Motohiro KOSAKI <redmine@...>
2011/02/15
Issue #4400 has been updated by Motohiro KOSAKI.
[#35332] [ANN] Planned maintenance of redmine.ruby-lang.org — "Yuki Sonoda (Yugui)" <yugui@...>
-----BEGIN PGP SIGNED MESSAGE-----
4 messages
2011/02/22
[#35352] Re: [ANN] Planned maintenance of redmine.ruby-lang.org
— "Yuki Sonoda (Yugui)" <yugui@...>
2011/02/23
-----BEGIN PGP SIGNED MESSAGE-----
[#35340] odd require behavior — Roger Pack <rogerdpack2@...>
Hello all.
5 messages
2011/02/22
[#35355] eval'ing large strings runs out of stack space? — Roger Pack <rogerdpack2@...>
Hello all.
7 messages
2011/02/23
[#35356] suggestion: default irb to saving history — Roger Pack <rogerdpack2@...>
Hello all.
3 messages
2011/02/24
[#35376] [Ruby 1.9 - Feature #4447] [Open] add String#byteslice() method — Suraj Kurapati <sunaku@...>
11 messages
2011/02/25
[#35378] Re: [Ruby 1.9 - Feature #4447] [Open] add String#byteslice() method
— "Martin J. Dürst" <duerst@...>
2011/02/25
string.force_encoding(ENCODING::BINARY).slice almost does what you want,
[#35379] Re: [Ruby 1.9 - Feature #4447] [Open] add String#byteslice() method
— Gary Wright <gwtmp01@...>
2011/02/25
[ruby-core:35329] [Ruby 1.9-Feature#4423][Open] [ext/openssl] Allow encryption for PEM-encoding Elliptic Curve private keys
From:
Martin Bosslet <redmine@...>
Date:
2011-02-21 23:36:21 UTC
List:
ruby-core #35329
Feature #4423: [ext/openssl] Allow encryption for PEM-encoding Elliptic Curve private keys http://redmine.ruby-lang.org/issues/show/4423 Author: Martin Bosslet Status: Open, Priority: Normal Category: ext, Target version: 1.9.3 There has already been some #if 0-excluded code that would actually take care of this, but it has not been implemented yet. The attached patch allows to encrypt PEM-encoded private keys, Cipher and password are ignored in the case of public keys (rather than raising an error). The motivation for this patch is that it would provide uniform behavior of all three public key systems supported in Ruby, RSA, DSA (who already support PEM encryption) and now also Elliptic Curve. RDoc has been supplemented. Regards, Martin ---------------------------------------- http://redmine.ruby-lang.org
Attachments (1)
ec_pem_pwd.diff
(3.37 KB, text/x-diff)
Index: ruby/ext/openssl/ossl_pkey_ec.c
===================================================================
--- ruby/ext/openssl/ossl_pkey_ec.c (revision 30938)
+++ ruby/ext/openssl/ossl_pkey_ec.c (working copy)
@@ -457,16 +457,13 @@
return (EC_KEY_get0_private_key(ec) ? Qtrue : Qfalse);
}
-static VALUE ossl_ec_key_to_string(VALUE self, int format)
+static VALUE ossl_ec_key_to_string(VALUE self, VALUE ciph, VALUE pass, int format)
{
EC_KEY *ec;
BIO *out;
int i = -1;
int private = 0;
-#if 0 /* unused now */
- EVP_CIPHER *cipher = NULL;
char *password = NULL;
-#endif
VALUE str;
Require_EC_KEY(self, ec);
@@ -486,37 +483,26 @@
switch(format) {
case EXPORT_PEM:
if (private) {
-#if 0 /* unused now */
- if (cipher || password)
-/* BUG: finish cipher/password key export */
- rb_notimplement();
+ const EVP_CIPHER *cipher;
+ if (!NIL_P(ciph)) {
+ cipher = GetCipherPtr(ciph);
+ if (!NIL_P(pass)) {
+ password = StringValuePtr(pass);
+ }
+ }
+ else {
+ cipher = NULL;
+ }
i = PEM_write_bio_ECPrivateKey(out, ec, cipher, NULL, 0, NULL, password);
-#endif
- i = PEM_write_bio_ECPrivateKey(out, ec, NULL, NULL, 0, NULL, NULL);
} else {
-#if 0 /* unused now */
- if (cipher || password)
- rb_raise(rb_eArgError, "encryption is not supported when exporting this key type");
-#endif
-
i = PEM_write_bio_EC_PUBKEY(out, ec);
}
break;
case EXPORT_DER:
if (private) {
-#if 0 /* unused now */
- if (cipher || password)
- rb_raise(rb_eArgError, "encryption is not supported when exporting this key type");
-#endif
-
i = i2d_ECPrivateKey_bio(out, ec);
} else {
-#if 0 /* unused now */
- if (cipher || password)
- rb_raise(rb_eArgError, "encryption is not supported when exporting this key type");
-#endif
-
i = i2d_EC_PUBKEY_bio(out, ec);
}
@@ -539,12 +525,20 @@
/*
* call-seq:
* key.to_pem => String
+ * key.to_pem(cipher, pass_phrase) => String
*
- * See the OpenSSL documentation for PEM_write_bio_ECPrivateKey()
+ * Outputs the EC key in PEM encoding. If +cipher+ and +pass_phrase+ are
+ * given they will be used to encrypt the key. +cipher+ must be an
+ * OpenSSL::Cipher::Cipher instance. Note that encryption will only be
+ * effective for a private key, public keys will always be encoded in plain
+ * text.
+ *
*/
-static VALUE ossl_ec_key_to_pem(VALUE self)
+static VALUE ossl_ec_key_to_pem(int argc, VALUE *argv, VALUE self)
{
- return ossl_ec_key_to_string(self, EXPORT_PEM);
+ VALUE cipher, passwd;
+ rb_scan_args(argc, argv, "02", &cipher, &passwd);
+ return ossl_ec_key_to_string(self, cipher, passwd, EXPORT_PEM);
}
/*
@@ -555,7 +549,7 @@
*/
static VALUE ossl_ec_key_to_der(VALUE self)
{
- return ossl_ec_key_to_string(self, EXPORT_DER);
+ return ossl_ec_key_to_string(self, Qnil, Qnil, EXPORT_DER);
}
/*
@@ -1526,7 +1520,7 @@
rb_define_method(cEC, "dsa_verify_asn1", ossl_ec_key_dsa_verify_asn1, 2);
/* do_sign/do_verify */
- rb_define_method(cEC, "to_pem", ossl_ec_key_to_pem, 0);
+ rb_define_method(cEC, "to_pem", ossl_ec_key_to_pem, -1);
rb_define_method(cEC, "to_der", ossl_ec_key_to_der, 0);
rb_define_method(cEC, "to_text", ossl_ec_key_to_text, 0);