[ruby-core:117552] [Ruby master Feature#20396] ObjectSpace.dump_all(string_value: false): skip dumping the String contents
From:
"byroot (Jean Boussier) via ruby-core" <ruby-core@...>
Date:
2024-04-17 08:41:37 UTC
List:
ruby-core #117552
Issue #20396 has been updated by byroot (Jean Boussier). > I see no reason to keep them. It is practically proven unnecessary I disagree. Just to give one example among many, it's very useful when tracking memory leaks. For instance you notice some pattern of a Hash growing, being able from the dump to see the content of the key often allow to map that object to actual code. I also use it very frequently to find opportunities for string deduplication via `heap-profiler`, e.g. https://github.com/rmosolgo/graphql-ruby/pull/4897 I'm totally fine with making it opt-in, but I'd like to keep the capability. ---------------------------------------- Feature #20396: ObjectSpace.dump_all(string_value: false): skip dumping the String contents https://bugs.ruby-lang.org/issues/20396#change-107947 * Author: byroot (Jean Boussier) * Status: Open ---------------------------------------- `ObjectSpace.dump_all` is a very useful method to debug memory leaks and such, hence is frequently needed in production. But since all the 7bit strings content is included in the dump, it incur the risk of leaking personal data, or secrets. Also, in many case the strings content isn't that helpful and is just making the dump much bigger for no good reason. And only pure-ASCII strings are dumped this way, which means all the tools that process these dumps should already be compatible with a dump without any string content. ### Feature I propose to add another optional parameter to `dump_all`: `string_value: false`. When passed, no String content is ever dumped regardless of its coderange. Implementation: https://github.com/ruby/ruby/pull/10382 cc @zzak -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/