[#107867] Fwd: [ruby-cvs:91197] 8f59482f5d (master): add some tests for Unicode Version 14.0.0 — Martin J. Dürst <duerst@...>
To everybody taking care of continuous integration:
3 messages
2022/03/13
[#108090] [Ruby master Bug#18666] No rule to make target 'yaml/yaml.h', needed by 'api.o' — duerst <noreply@...>
Issue #18666 has been reported by duerst (Martin D端rst).
7 messages
2022/03/28
[#108117] [Ruby master Feature#18668] Merge `io-nonblock` gems into core — "Eregon (Benoit Daloze)" <noreply@...>
Issue #18668 has been reported by Eregon (Benoit Daloze).
22 messages
2022/03/30
[ruby-core:108082] [Ruby master Bug#18294] error when parsing regexp comment
From:
"jeremyevans0 (Jeremy Evans)" <noreply@...>
Date:
2022-03-26 02:26:58 UTC
List:
ruby-core #108082
Issue #18294 has been updated by jeremyevans0 (Jeremy Evans). I've submitted a pull request to fix this: https://github.com/ruby/ruby/pull/5721 The basic approach is skip the parse.y checks for regexps, because regexp does the same checks. Modify the regexp code to pass the regexp options to a couple of internal functions, and in the function that handles the unescaping, recognize `#` and ignore characters until the end of the line. This becomes complicated, because `#` is allowed as a regular, non-comment character, inside a character class `[]`. So attempt to handle that. Additionally, I found this issue is not limited to extended regexps, it affects all regexps using `(?#` comments. So try to handle those comments as well by ignoring content inside them. I'm not sure the pull request handles all cases, and I'm also not sure it doesn't introduce regressions. It would great if a more knowledgeable committer could review it. The patch is kind of a hack. A better fix would be to integrate the unescaping code with the regexp parsing code, instead of trying to unescape in a first pass, before parsing in a later pass. This would allow the unescaping to be aware of the regexp parser state, making it simple to avoid unescaping when inside a regexp comment. ---------------------------------------- Bug #18294: error when parsing regexp comment https://bugs.ruby-lang.org/issues/18294#change-97040 * Author: thyresias (Thierry Lambert) * Status: Open * Priority: Normal * ruby -v: ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [i386-mingw32] * Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN ---------------------------------------- The following code generates the error "too short escaped multibyte character" ``` ruby _re = / foo # \M-ca /x ``` Removing the \ or doubling it makes the error disappear. Since this is in comment text, I would expect to be able to type anything there: am I missing something? -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>