[ruby-core:104920] [Ruby master Bug#16836] configure-time LDFLAGS leak into ruby pkg-config file
From:
michael+ruby@...
Date:
2021-08-14 09:10:45 UTC
List:
ruby-core #104920
Issue #16836 has been updated by stapelberg (Michael Stapelberg). Thanks for taking a look! jeremyevans0 (Jeremy Evans) wrote in #note-1: > According to the history, adding `DLDFLAGS` to `Libs` was a deliberate decision made back in 2010 in commit:51d25ca8c0eb7da192f5bdf2729fc856e8f81a9d. Assigning to @nobu as he was the one that made the change. I'm guessing there are environments where using `DLDFLAGS` is required for correct functioning, so reverting the commit is unlikely to be an option. Perhaps the situation has changed in the 11 years since that commit, though :) I took a look, but the commit doesn’t seem to mention any rationale for making the change. > This sounds like something you could just easily patch out in distri. It looks like distri is still not recommended for production use according to https://distr1.org/, so the current behavior seems unlikely to affect users. That’s correct, distri is a research project and doesn’t directly serve users in that sense. However, I figured that if it’s a problem for distri, it’s likely a problem for other hermetic environments, either now or in the future, so correctness bugs like these are good to fix upstream. If that turns out to be incorrect and nobody else cares, then fine, but I wanted to at least report it :) ---------------------------------------- Bug #16836: configure-time LDFLAGS leak into ruby pkg-config file https://bugs.ruby-lang.org/issues/16836#change-93284 * Author: stapelberg (Michael Stapelberg) * Status: Assigned * Priority: Normal * Assignee: nobu (Nobuyoshi Nakada) * ruby -v: 2.7.1 * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- When building ruby with e.g. `-Wl,-rpath=/ro/ruby-amd64-2.7.1-6/lib` (to make it hermetic, see my work-in-progress post at https://website-review.zekjur.net/pull/hermetic/posts/2020-05-04-distri-hermetic-packages/), I noticed that the resulting pkg-config file (`lib/pkgconfig/ruby-2.7.pc`) includes the LDFLAGS! This will result in software that links against ruby being built with the wrong `rpath`. In general, LDFLAGS should not be persisted into pkg-config. The attached patch fixes the issue. Thanks, ---Files-------------------------------- pc-ldflags.patch (563 Bytes) -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>