[ruby-core:102058] [Ruby master Bug#17429] Prohibit include/prepend in refinement modules
From:
ronnie@...
Date:
2021-01-13 08:08:20 UTC
List:
ruby-core #102058
Issue #17429 has been updated by matsuda (Akira Matsuda). Calling include in refinement modules has certin use cases. Here's an actual example. https://github.com/tomykaira/rspec-parameterized/blob/v0.4.2/lib/rspec/parameterized/table_syntax.rb#L27-L61 This gem uses Module#include to avoid code repetition, which to me looks quite natural and basic usage of Module. If we prohibit include in refinement modules, can this code still be written equally simply? ---------------------------------------- Bug #17429: Prohibit include/prepend in refinement modules https://bugs.ruby-lang.org/issues/17429#change-89916 * Author: shugo (Shugo Maeda) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- include/prepend in refinement modules has implementation difficulties such as #17007 and #17379, and tends to be misleading like #17374. How about to prohibit it in future versions? Method copy like #17380 may be more convenient, but it's confusing to use names include and prepend because semantics is different from the original ones. -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>